Initial reorg e2e tests and verifier adjustment #346
+755
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asoliman92
reviewed
Nov 19, 2025
build/devenv/services/verifier.go
Outdated
| ) | ||
|
|
||
| // FinalityConfig holds finality configuration for a specific chain. | ||
| type FinalityConfig struct { |
Contributor
There was a problem hiding this comment.
I don't think we should add this to the real config, we can just make it in main.go for the standalone directly. HeadTracker should already abstracts this away from us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a comprehensive end-to-end finality testing framework for CCV, focusing on message ordering and chain reorg scenarios. It adds a dedicated GitHub Actions workflow for finality tests, new configuration options for finality modes and depths, and supporting code to ensure Anvil test chains operate correctly with automining. The changes also include a new E2E test that validates finality behavior during chain reorgs and message ordering.