build/devenv: support multiple executors in deployment #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makramkd
commented
Nov 21, 2025
Comment on lines
+258
to
+263
| logger: log. | ||
| Output(zerolog.ConsoleWriter{Out: os.Stderr}). | ||
| Level(zerolog.DebugLevel). | ||
| With(). | ||
| Fields(map[string]any{"component": "CCIP17EVM"}). | ||
| Logger(), |
Collaborator
Author
There was a problem hiding this comment.
We were previously creating the object with just &CCIP17EVM{} which set a null logger, meaning lots of logs were not actually being logged to the console. This fixes that.
|
Code coverage report:
|
makramkd
commented
Nov 21, 2025
| working-directory: build/devenv/tests/e2e | ||
| run: | | ||
| set -o pipefail | ||
| go test -v -timeout 15m -count=1 -run 'TestE2ESmoke' -json \ |
Collaborator
Author
There was a problem hiding this comment.
Removing this due to noise from the comments, they're already unweildly.
Comment on lines
-160
to
+165
| // FundNodes Fund Chainlink nodes for some amount of native/LINK currency | ||
| // FundNodes funds Chainlink nodes for some amount of native/LINK currency | ||
| // using chain-specific clients or CLDF | ||
| FundNodes(ctx context.Context, cls []*nodeset.Input, bc *blockchain.Input, linkAmount, nativeAmount *big.Int) error | ||
| // FundAddresses funds addresses for some amount of native currency | ||
| // using chain-specific clients or CLDF | ||
| FundAddresses(ctx context.Context, bc *blockchain.Input, addresses []protocol.UnknownAddress, nativeAmount *big.Int) error |
Collaborator
Author
There was a problem hiding this comment.
These are very similar - could they be combined gracefully?
0xAustinWang
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket