Skip to content

SafeTagSupported safe pointer handling #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

SafeTagSupported safe pointer handling #287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c658c57
safe pointer
stackman27 Oct 24, 2025
a4bfd4e
fix lint issue
Unheilbar Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/config/chain_scoped.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ func (e *EVMConfig) FinalityTagEnabled() bool {
}

func (e *EVMConfig) SafeTagSupported() bool {
if e == nil || e.C == nil || e.C.SafeTagSupported == nil {
return false
}
Comment on lines +116 to +118
Copy link
Collaborator

@jmank88 jmank88 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the default set in the TOML definition? The config tests ensure that these are not left nil.

Suggested change
if e == nil || e.C == nil || e.C.SafeTagSupported == nil {
return false
}

Copy link
Collaborator

@jmank88 jmank88 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set (and the default is actually true FWIW), and I confirmed it comes through as non-nil. In what circumstances did you encounter nil?

Copy link
Contributor

@silaslenihan silaslenihan Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the default is set here

Copy link
Contributor

@0xAustinWang 0xAustinWang Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the error I'm seeing on staging. Nodes are crashing

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1c3dd67]
goroutine 4242 [running]:
github.com/smartcontractkit/chainlink-evm/pkg/config.(*EVMConfig).SafeTagSupported(0x4?)
	/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/config/chain_scoped.go:116 +0x7
github.com/smartcontractkit/chainlink-framework/chains/heads.(*tracker[...]).LatestSafeBlock(0x81c8ec0, {0x813eab8, 0xc01c4e2500})
	/go/pkg/mod/github.com/smartcontractkit/chainlink-framework/[email protected]/heads/tracker.go:407 +0x66
github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).latestSafeBlock(0xc001537860, {0x813eab8?, 0xc01c4e2500?}, 0x43497fc)
	/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:1172 +0x3a
github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).pollAndSaveLogs(0xc001537860, {0x813eab8, 0xc01c4e2500}, 0x4348b7e)
	/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:1061 +0x22a
github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).PollAndSaveLogs(0xc001537860, {0x813eab8?, 0xc01c4e2500?}, 0x0?)
	/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:1032 +0x26
github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).run(0xc001537860)
	/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:665 +0x50a
created by github.com/smartcontractkit/chainlink-evm/pkg/logpoller.(*logPoller).Start.func1 in goroutine 1
	/go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/logpoller/log_poller.go:520 +0x69

Copy link
Contributor

@0xAustinWang 0xAustinWang Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to bump staging from this PR: https://github.com/smartcontractkit/infra-k8s/pull/31871/files

the chainlink-evm version in the image is from yesterday: https://github.com/smartcontractkit/chainlink-evm/tree/b2ed6162042f84f7d91b3d588a4a7e616cd1de6f

Copy link
Contributor

@silaslenihan silaslenihan Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmank88 is there elsewhere we need to set defaults?

Copy link
Contributor

@0xAustinWang 0xAustinWang Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's the staging deployment, it seems like the nodes are healthier than earlier but hard to tell without the monitoring
https://argo.main.stage.cldev.sh/applications/cl-ccip-v2-testnet

Copy link
Collaborator

@jmank88 jmank88 Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is set in the correct place. Is this value being used without applying the defaults?

return *e.C.SafeTagSupported
}

Expand Down
Loading