Skip to content

Conversation

@kaleofduty
Copy link
Contributor

@kaleofduty kaleofduty commented Nov 16, 2025

The most interesting part is how channel adder authorization works in two steps, setting the allowed channelAdders for a DON, and then the authorized address for a given channelAdder.

allowed channelAdders for a DON:

  • Each DON maintains a set of allowed channelAdderIds
  • Set by owner via setChannelAdder(donId, channelAdderId, bool)

authorized address for a given channelAdder:

  • Each channelAdderId (uint32) maps to exactly one address
  • Set by owner via setChannelAdderAddress(channelAdderId, address)

@octane-security-app
Copy link

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

  • ChannelConfigStore.sol: The contract now supports channel adders with address assignments, authorization management, and the ability to add channel definitions.

🔗 Commit Hash: 86e677d

@kaleofduty kaleofduty requested a review from brunotm November 16, 2025 22:26
@github-actions
Copy link
Contributor

github-actions bot commented Nov 16, 2025

Static analysis results are available

Hey @brunotm, you can view Slither reports in the job summary here or download them as artifact here.
Please check them before merging and make sure you have addressed all issues.

@octane-security-app
Copy link

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉


🔗 Commit Hash: 86e677d

/// @param channelAdderId The channel adder ID
/// @param url The URL of the channel definition
/// @param sha The SHA hash of the channel definition
function addChannelDefinitions(
Copy link
Contributor

@akuzni2 akuzni2 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this function check that a s_channelDefinitionVersions exists for particular donId i.e. we've called setChannelDefinitions at least once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants