Skip to content

adding reportFail on forwarder with go tests #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 30 commits into
base: develop
Choose a base branch
from
Open

adding reportFail on forwarder with go tests #1383

wants to merge 30 commits into from

Conversation

@yashnevatia
Copy link
Contributor

@yashnevatia yashnevatia commented Nov 12, 2025 •
edited
Loading

Description

  • Added a new function called report_failure
  • It takes exactly the same context as report
  • report_failure
    • verifies signature
    • verifies account hash
    • proceeds to mark execution as failed

https://smartcontract-it.atlassian.net/browse/PLEX-1927

Requires Dependencies

Resolves Dependencies

@yashnevatia yashnevatia requested review from a team as code owners November 12, 2025 16:42
@github-actions
Copy link
Contributor

github-actions bot commented Nov 12, 2025

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Nov 19, 2025

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PabloMansanet PabloMansanet PabloMansanet left review comments

@augustbleeds augustbleeds augustbleeds left review comments

@ilija42 ilija42 Awaiting requested review from ilija42

@ogtownsend ogtownsend Awaiting requested review from ogtownsend

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yashnevatia @PabloMansanet @augustbleeds