[WIP] Enhancement: improve package id resolution methods#234
Merged
faisal-chainlink merged 4 commits intofix/nonevm-2986from Nov 21, 2025
Merged
Conversation
faisal-chainlink
added a commit
that referenced
this pull request
Nov 24, 2025
* deduct storage rebase from gas estimation cost * if storage rebate failed to get parsed, set it to 0 * add a check around updating a transaction state into the same value as the old state * update txm tests * ensure that gas coins are not locked * fix failing tests * udpate fake client * update mock and fake client * Chore: misc tests cleanup (#110) * remove outdated offramp test in favor of execute_test.go * remove outdated client setup from txm test * use time out SDK client in bindings * update onramp integration to use the unified setup for test env * remove /knowledge_base directory in favor of /documentation * put pack the execute offramp test * experiment * disable offramp integration test in favor of E2E tests * remove the offramp integration test in favor of the E2E test now running in CI * update nix checksum * Enhancement: improve package id resolution methods (#234) * add validation of token pool config response in offramp execution flow * misc improvements to fetching the latest package ID * misc lint edits * run binding regen * update integration test * tidy
faisal-chainlink
added a commit
that referenced
this pull request
Jan 5, 2026
* deduct storage rebase from gas estimation cost * if storage rebate failed to get parsed, set it to 0 * add a check around updating a transaction state into the same value as the old state * update txm tests * ensure that gas coins are not locked * fix failing tests * udpate fake client * update mock and fake client * Chore: misc tests cleanup (#110) * remove outdated offramp test in favor of execute_test.go * remove outdated client setup from txm test * use time out SDK client in bindings * update onramp integration to use the unified setup for test env * remove /knowledge_base directory in favor of /documentation * put pack the execute offramp test * experiment * disable offramp integration test in favor of E2E tests * remove the offramp integration test in favor of the E2E test now running in CI * update nix checksum * Enhancement: improve package id resolution methods (#234) * add validation of token pool config response in offramp execution flow * misc improvements to fetching the latest package ID * misc lint edits * run binding regen * update integration test * tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.