-
Notifications
You must be signed in to change notification settings - Fork 0
Fix: use hex for transaction digest in events #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
👋 faisal-chainlink, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
do you need to update only e2e tests in core or you need to update some actual logic in core? |
The actual core logic. Primarily just the part that reads the tx digest part of the events to state machine changes / transaction state signals in core. |
The E2E tests for this are expected to fail until core is updated to handle the hex tx digest instead of bytes.