Add changeset to add bidirectional lanes #17015
Conversation
kylesmartin
requested review from
winder,
asoliman92,
matYang,
makramkd,
dimkouv,
0xAustinWang and
b-gopalswami
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
| UpdateRouterRampsConfig UpdateRouterRampsConfig | ||
| } | ||
|
|
||
| func (c AddBidirectionalLanesConfig) buildConfigs() addBidirectionalLanesChangesetConfigs { |
There was a problem hiding this comment.
let's add an unit test for this func
| onRampUpdatesByChain[laneDef.Source.Selector] = make(map[uint64]OnRampDestinationUpdate) | ||
| } | ||
| onRampUpdatesByChain[laneDef.Source.Selector][laneDef.Dest.Selector] = OnRampDestinationUpdate{ | ||
| IsEnabled: true, |
There was a problem hiding this comment.
Suggestion : Can you take this as input? It might help disabling lane with same changeset
There was a problem hiding this comment.
Sure, I will add an IsDisabled option though because enabling a lane should be default action.
| feeQuoterPriceUpdatesOnSource := feeQuoterPriceUpdatesByChain[laneDef.Source.Selector] | ||
| if feeQuoterPriceUpdatesOnSource.GasPrices == nil { | ||
| feeQuoterPriceUpdatesOnSource.GasPrices = make(map[uint64]*big.Int) | ||
| } | ||
| feeQuoterPriceUpdatesOnSource.GasPrices[laneDef.Dest.Selector] = laneDef.Dest.GasPrice | ||
| feeQuoterPriceUpdatesByChain[laneDef.Source.Selector] = feeQuoterPriceUpdatesOnSource | ||
| } | ||
| } |
There was a problem hiding this comment.
are you missing the token prices here?
There was a problem hiding this comment.
Token prices are not tied to a dest chain selector. They are tied to token addresses on the source chain. That is to say that when you add a lane, you shouldn't be adding a new token price. These should already exist.
If you need to add a new token price to a chain, that is a separate process and should not go through "add lane".
| return nil | ||
| } | ||
|
|
||
| func addBidirectionalLanesLogic(e deployment.Environment, c AddBidirectionalLanesConfig) (deployment.ChangesetOutput, error) { |
There was a problem hiding this comment.
nit: log statements after every success operation. Ignore if there are already log statements available in individual changesets
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌2 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌2 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
|
Flakeguard SummaryRan new or updated tests between View Flaky Detector Details | Compare Changes Found Flaky Tests ❌1 Results
ArtifactsFor detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json. |
https://smartcontract-it.atlassian.net/browse/CCIP-5502