Skip to content

[PRIV-88] First pass at vault plugin with GetSecrets and CreateSecrets implemented #18535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Jul 16, 2025
Merged

[PRIV-88] First pass at vault plugin with GetSecrets and CreateSecrets implemented #18535

merged 25 commits into from
Jul 16, 2025
+3,154 −27

Conversation

cedric-cordenier
Copy link
Contributor

Requires

Supports

@cedric-cordenier cedric-cordenier force-pushed the PRIV-88-vault-plugin branch 3 times, most recently from 0af544d to 376f658 Compare July 9, 2025 14:23
@cedric-cordenier cedric-cordenier force-pushed the PRIV-88-vault-plugin branch 3 times, most recently from 87d1716 to 2399506 Compare July 10, 2025 16:59
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cedric-cordenier cedric-cordenier changed the title Priv 88 vault plugin [PRIV-88] First pass at vault plugin with GetSecrets and CreateSecrets implemented Jul 11, 2025
@cedric-cordenier cedric-cordenier force-pushed the PRIV-88-vault-plugin branch 3 times, most recently from dfbc370 to 33459eb Compare July 11, 2025 12:25
@cedric-cordenier cedric-cordenier marked this pull request as ready for review July 11, 2025 12:26
@cedric-cordenier cedric-cordenier requested review from a team as code owners July 11, 2025 12:26
@cedric-cordenier cedric-cordenier force-pushed the PRIV-88-vault-plugin branch 4 times, most recently from c10895c to 05fdd02 Compare July 16, 2025 11:28
@cedric-cordenier cedric-cordenier force-pushed the PRIV-88-vault-plugin branch 2 times, most recently from ce05e5a to bcebd5e Compare July 16, 2025 12:22
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
1 New Critical Issues (required ≤ 0)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE SonarQube IDE

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jul 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 16, 2025
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jul 16, 2025
Merged via the queue into develop with commit e7eb25a Jul 16, 2025
160 of 162 checks passed
@cedric-cordenier cedric-cordenier deleted the PRIV-88-vault-plugin branch July 16, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolekk bolekk bolekk left review comments

@DeividasK DeividasK DeividasK left review comments

@prashantkumar1982 prashantkumar1982 prashantkumar1982 left review comments

@ChrisAmora ChrisAmora ChrisAmora approved these changes

@george-dorin george-dorin george-dorin approved these changes

@DylanTinianov DylanTinianov Awaiting requested review from DylanTinianov DylanTinianov is a code owner automatically assigned from smartcontractkit/foundations

@ecPablo ecPablo Awaiting requested review from ecPablo

@gustavogama-cll gustavogama-cll Awaiting requested review from gustavogama-cll

@kalverra kalverra Awaiting requested review from kalverra

@skudasov skudasov Awaiting requested review from skudasov

@Tofel Tofel Awaiting requested review from Tofel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cedric-cordenier @bolekk @DeividasK @ChrisAmora @prashantkumar1982 @george-dorin