Skip to content

Comments

Add router_state_address to Aptos Onramp#18882

Open
JohnChangUK wants to merge 15 commits intodevelopfrom
aptos-update
Open

Add router_state_address to Aptos Onramp#18882
JohnChangUK wants to merge 15 commits intodevelopfrom
aptos-update

Conversation

@JohnChangUK
Copy link
Contributor

@JohnChangUK JohnChangUK commented Aug 7, 2025 •
edited
Loading

Desc

Add router_state_address to Aptos Onramp. This is from the OnrampV2 change from the Aptos contracts.

@JohnChangUK JohnChangUK requested review from a team as code owners August 7, 2025 23:59
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2025

👋 JohnChangUK, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@JohnChangUK JohnChangUK mentioned this pull request Aug 7, 2025
Merged
@JohnChangUK JohnChangUK force-pushed the aptos-update branch 3 times, most recently from 71d1676 to fe5990f Compare August 8, 2025 00:49
@JohnChangUK JohnChangUK requested a review from a team as a code owner December 3, 2025 15:10
@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Dec 3, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

This PR is stale because it has been open days with no activity.
Remove the stale label, comment, or update this PR to prevent this PR from being closed in days.

@github-actions github-actions bot added the Stale label Feb 2, 2026
@jmank88
Copy link
Contributor

jmank88 commented Feb 6, 2026

@JohnChangUK Will this be revived? or can we close it?

@chainchad chainchad mentioned this pull request Feb 6, 2026
Merged
@github-actions github-actions bot removed the Stale label Feb 7, 2026
@jmank88
Copy link
Contributor

jmank88 commented Feb 9, 2026

Closing to silence notifications

@jmank88 jmank88 closed this Feb 9, 2026
@JohnChangUK JohnChangUK reopened this Feb 16, 2026
@JohnChangUK
Copy link
Contributor Author

JohnChangUK commented Feb 16, 2026

Closing to silence notifications

Reopening, will execute upgrade this week

@JohnChangUK JohnChangUK force-pushed the aptos-update branch 2 times, most recently from 049a26e to 14e1f8f Compare February 17, 2026 19:31
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2026

✅ No conflicts with other open PRs targeting develop

@cl-sonarqube-production
Copy link

cl-sonarqube-production bot commented Feb 21, 2026

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jmank88 jmank88 jmank88 approved these changes

@cfal cfal cfal left review comments

@rodrigombsoares rodrigombsoares rodrigombsoares left review comments

@winder winder Awaiting requested review from winder winder is a code owner automatically assigned from smartcontractkit/ccip-offchain

@asoliman92 asoliman92 Awaiting requested review from asoliman92 asoliman92 is a code owner automatically assigned from smartcontractkit/ccip-offchain

@matYang matYang Awaiting requested review from matYang matYang is a code owner automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner automatically assigned from smartcontractkit/ccip-offchain

@agusaldasoro agusaldasoro Awaiting requested review from agusaldasoro agusaldasoro is a code owner automatically assigned from smartcontractkit/ccip-offchain

@dimkouv dimkouv Awaiting requested review from dimkouv dimkouv is a code owner automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami is a code owner automatically assigned from smartcontractkit/ccip-offchain

@ecPablo ecPablo Awaiting requested review from ecPablo

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@ajaskolski ajaskolski Awaiting requested review from ajaskolski

@bytesizedroll bytesizedroll Awaiting requested review from bytesizedroll

@CL-Eric CL-Eric Awaiting requested review from CL-Eric

@DimitriosNaikopoulos DimitriosNaikopoulos Awaiting requested review from DimitriosNaikopoulos

@giogam giogam Awaiting requested review from giogam

@graham-chainlink graham-chainlink Awaiting requested review from graham-chainlink

@jkongie jkongie Awaiting requested review from jkongie

@securejavier securejavier Awaiting requested review from securejavier

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JohnChangUK @mchain0 @jmank88 @cfal @rodrigombsoares