Stop logging requests in the Vault DON #20406
Open
+12
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-security-plaid-production
bot
requested review from
fernandezlautaro,
michael-cll and
patrickhuie19
Contributor
|
👋 cedric-cordenier, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
I see you updated files related to
|
shileiwill
reviewed
Nov 20, 2025
| } | ||
| r.lggr.Infow("AuthorizeRequest success in auth", "method", req.Method, "requestID", req.ID, "authorizedRequestStr", authorizedRequestStr) | ||
| r.alreadyAuthorizedRequests[authorizedRequestStr] = int64(allowlistedRequest.ExpiryTimestamp) | ||
| return true, allowlistedRequest.Owner.Hex(), nil |
![trunk-io[bot]](https://avatars.githubusercontent.com/in/120106?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔴 Test Results: Unrelated Failure
Affected failures:
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNUncurseForceOption
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNUncurse
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNCurseConfigValidate
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNCurseOneConnectedLanesSolana
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_messaging_test.go:Test_CCIPMessaging_Solana2EVM
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_sui_upgrade_test.go:Test_CCIP_Upgrade_EVM2Sui
What Broke
These failures appear to be unrelated to the changes in this PR. The CI jobs consistently failed due to an external dependency issue: an inability to download necessary program artifacts (such as Solana or suiup) from GitHub releases. This was caused by a 503 server error, indicating a problem with the external GitHub service or network connectivity. These download failures prevented critical components from starting, leading to the observed job failures. The changes introduced in the PR are confined to internal logging and request authorization logic, which have no direct impact on external artifact downloads or environment setup.
Autofix Options
You can use our MCP server to get AI assistance with debugging and fixing these failures.
- Use MCP in your IDE to debug the issue. Try
Help me fix CI failures from q8FMfnrlto get started.
There was a problem hiding this comment.
🔴 Test Results: Bypassed Authorization Logic
Affected failures:
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_sui_upgrade_test.go:Test_CCIP_Upgrade_NoBlock_EVM2Sui
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_cs_rmn_curse_uncurse_test.go:TestRMNUncurseMCMS
What Broke
The PR's modifications bypassed crucial authorization logic within the vault capability, which is essential for the CCIP protocol's commitment process. This bypass also prevented the Solana container from starting correctly during integration tests.
Proposed Fixes
Revert the changes made to the AuthorizeRequest function in core/capabilities/vault/request_authorizer.go, restoring the original authorization logic and re-adding necessary imports.
+ "encoding/hex"
"encoding/json"
+ "errors"
+ "fmt"- return true, "owner1", nil
+ defer r.clearExpiredAuthorizedRequests()
+ r.lggr.Infow("AuthorizeRequest", "method", req.Method, "requestID", req.ID)
+ requestDigest, err := req.Digest()
+ if err != nil {
+ r.lggr.Infow("AuthorizeRequest failed to create digest", "method", req.Method, "requestID", req.ID)
+ return false, "", err
+ }
+ requestDigestBytes, err := hex.DecodeString(requestDigest)
+ if err != nil {
+ r.lggr.Infow("AuthorizeRequest failed to decode digest", "method", req.Method, "requestID", req.ID)
+ return false, "", err
+ }
+ requestDigestBytes32 := [32]byte(requestDigestBytes)
+ if r.workflowRegistrySyncer == nil {
+ r.lggr.Errorw("AuthorizeRequest workflowRegistrySyncer is nil", "method", req.Method, "requestID", req.ID)
+ return false, "", errors.New("internal error: workflowRegistrySyncer is nil")
+ }
+ allowedRequests := r.workflowRegistrySyncer.GetAllowlistedRequests(ctx)
+ allowedRequestsStrs := make([]string, 0, len(allowedRequests))
+ for _, rr := range allowedRequests {
+ allowedReqStr := fmt.Sprintf("Owner: %s, RequestDigest: %s, ExpiryTimestamp: %d", rr.Owner.Hex(), hex.EncodeToString(rr.RequestDigest[:]), rr.ExpiryTimestamp)
+ allowedRequestsStrs = append(allowedRequestsStrs, allowedReqStr)
+ }
+ r.lggr.Infow("AuthorizeRequest GetAllowlistedRequests", "method", req.Method, "requestID", req.ID, "allowedRequests", allowedRequestsStrs)
+ allowlistedRequest := r.fetchAllowlistedItem(allowedRequests, requestDigestBytes32)
+ if allowlistedRequest == nil {
+ r.lggr.Infow("AuthorizeRequest fetchAllowlistedItem request not allowlisted",
+ "method", req.Method,
+ "requestID", req.ID,
+ "digestHexStr", requestDigest,
+ "allowedRequestsStrs", allowedRequestsStrs)
+ return false, "", errors.New("request not allowlisted")
+ }
+ authorizedRequestStr := string(allowlistedRequest.RequestDigest[:])
+
+ r.alreadyAuthorizedMutex.Lock()
+ defer r.alreadyAuthorizedMutex.Unlock()
+ if r.alreadyAuthorizedRequests[authorizedRequestStr] > 0 {
+ r.lggr.Infow("AuthorizeRequest already authorized previously", "method", req.Method, "requestID", req.ID, "authorizedRequestStr", authorizedRequestStr)
+ return false, "", errors.New("request already authorized previously")
+ }
+ if time.Now().UTC().Unix() > int64(allowlistedRequest.ExpiryTimestamp) {
+ r.lggr.Infow("AuthorizeRequest expired authorization", "method", req.Method, "requestID", req.ID, "authorizedRequestStr", authorizedRequestStr)
+ return false, "", errors.New("request authorization expired")
+ }
+ r.lggr.Infow("AuthorizeRequest success in auth", "method", req.Method, "requestID", req.ID, "authorizedRequestStr", authorizedRequestStr)
+ r.alreadyAuthorizedRequests[authorizedRequestStr] = int64(allowlistedRequest.ExpiryTimestamp)
+ return true, allowlistedRequest.Owner.Hex(), nilAutofix Options
You can apply the proposed fixes directly to your branch. Try the following:
- Comment
/trunk stack-fix KTG6LnkJto generate a stacked PR with the proposed fixes. - Use MCP in your IDE to fix the issue. Try
Help me fix CI failures from KTG6LnkJto get started.
Tip
Get Better Results: This CI job is not uploading test reports. Adding structured test reports enables more precise, test-level analysis with better root cause identification and more targeted fix recommendations.
👉🏻 Learn how to upload test results.
|
There was a problem hiding this comment.
🔴 Test Results: Authorization Logic Bypass
Affected failures:
- TestRequestAuthorizer_CreateSecrets (Workflow Run: Core Tests (go_core_tests))
- TestRequestAuthorizer_UpdateSecrets (Workflow Run: Core Tests (go_core_tests))
- TestRequestAuthorizer_DeleteSecrets (Workflow Run: Core Tests (go_core_tests))
- TestRequestAuthorizer_ListSecrets (Workflow Run: Core Tests (go_core_tests))
- Workflow Run: Integration Tests
- Workflow Run: Run CCIP integration In Memory Tests For PR / smoke/ccip/ccip_sui_token_transfer_test.go:Test_CCIPTokenTransfer_EVM2SUI_ManagedTokenPool
What Broke
These failures are caused by an alteration to the AuthorizeRequest function in core/capabilities/vault/request_authorizer.go. The function was changed to always return a hardcoded authorized state and owner, effectively bypassing the actual authorization logic. This led to integration tests failing because they expected dynamic authorization and a specific hexadecimal owner address, which was no longer being provided.
Proposed Fixes
Revert the changes to the AuthorizeRequest function in core/capabilities/vault/request_authorizer.go to restore the original authorization logic and re-add necessary imports.
+ "encoding/hex"
"encoding/json"
+ "errors"
+ "fmt"
"sync"
"time" func (r *requestAuthorizer) AuthorizeRequest(ctx context.Context, req jsonrpc.Request[json.RawMessage]) (isAuthorized bool, owner string, err error) {
- return true, "owner1", nil
+ defer r.clearExpiredAuthorizedRequests()
+ r.lggr.Infow("AuthorizeRequest", "method", req.Method, "requestID", req.ID)
+ requestDigest, err := req.Digest()
+ if err != nil {
+ r.lggr.Infow("AuthorizeRequest failed to create digest", "method", req.Method, "requestID", req.ID)
+ return false, "", err
+ }
+ requestDigestBytes, err := hex.DecodeString(requestDigest)
+ if err != nil {
+ r.lggr.Infow("AuthorizeRequest failed to decode digest", "method", req.Method, "requestID", req.ID)
+ return false, "", err
+ }
+ requestDigestBytes32 := [32]byte(requestDigestBytes)
+ if r.workflowRegistrySyncer == nil {
+ r.lggr.Errorw("AuthorizeRequest workflowRegistrySyncer is nil", "method", req.Method, "requestID", req.ID)
+ return false, "", errors.New("internal error: workflowRegistrySyncer is nil")
+ }
+ allowedRequests := r.workflowRegistrySyncer.GetAllowlistedRequests(ctx)
+ allowedRequestsStrs := make([]string, 0, len(allowedRequests))
+ for _, rr := range allowedRequests {
+ allowedReqStr := fmt.Sprintf("Owner: %s, RequestDigest: %s, ExpiryTimestamp: %d", rr.Owner.Hex(), hex.EncodeToString(rr.RequestDigest[:]), rr.ExpiryTimestamp)
+ allowedRequestsStrs = append(allowedRequestsStrs, allowedReqStr)
+ }
+ r.lggr.Infow("AuthorizeRequest GetAllowlistedRequests", "method", req.Method, "requestID", req.ID, "allowedRequests", allowedRequestsStrs)
+ allowlistedRequest := r.fetchAllowlistedItem(allowedRequests, requestDigestBytes32)
+ if allowlistedRequest == nil {
+ r.lggr.Infow("AuthorizeRequest fetchAllowlistedItem request not allowlisted",
+ "method", req.Method,
+ "requestID", req.ID,
+ "digestHexStr", requestDigest,
+ "allowedRequestsStrs", allowedRequestsStrs)
+ return false, "", errors.New("request not allowlisted")
+ }
+ authorizedRequestStr := string(allowlistedRequest.RequestDigest[:])
+
+ r.alreadyAuthorizedMutex.Lock()
+ defer r.alreadyAuthorizedMutex.Unlock()
+ if r.alreadyAuthorizedRequests[authorizedRequestStr] > 0 {
+ r.lggr.Infow("AuthorizeRequest already authorized previously", "method", req.Method, "requestID", req.ID, "authorizedRequestStr", authorizedRequestStr)
+ return false, "", errors.New("request already authorized previously")
+ }
+ if time.Now().UTC().Unix() > int64(allowlistedRequest.ExpiryTimestamp) {
+ r.lggr.Infow("AuthorizeRequest expired authorization", "method", req.Method, "requestID", req.ID, "authorizedRequestStr", authorizedRequestStr)
+ return false, "", errors.New("request authorization expired")
+ }
+ r.lggr.Infow("AuthorizeRequest success in auth", "method", req.Method, "requestID", req.ID, "authorizedRequestStr", authorizedRequestStr)
+ r.alreadyAuthorizedRequests[authorizedRequestStr] = int64(allowlistedRequest.ExpiryTimestamp)
+ return true, allowlistedRequest.Owner.Hex(), nil
}Autofix Options
You can apply the proposed fixes directly to your branch. Try the following:
- Comment
/trunk stack-fix sKV2xgx2to generate a stacked PR with the proposed fixes. - Use MCP in your IDE to fix the issue. Try
Help me fix CI failures from sKV2xgx2to get started.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports