fix: should return err not nil#21264
Open
cuiweixie wants to merge 1 commit intosmartcontractkit:developfrom
Open
fix: should return err not nil#21264cuiweixie wants to merge 1 commit intosmartcontractkit:developfrom
cuiweixie wants to merge 1 commit intosmartcontractkit:developfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the OCR2GenericPluginConfig.UnmarshalJSON method where an error from json.Unmarshal was being suppressed by returning nil instead of the actual error. This would cause unmarshaling failures to be silently ignored, leading to potentially invalid configurations being accepted.
Changes:
- Fixed error handling in
UnmarshalJSONto properly return the error instead ofnil
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports