Add Copper EA by cl-mayowa · Pull Request #3991 · smartcontractkit/external-adapters-js

cl-mayowa · 2025-09-03T14:27:20Z

Closes #OPDATA-3656

Description

This PR adds Copper EA as one of the EA to complete the solstice PoR endpoint.
......

Changes

Added wallets endpoint
Added subscription transport
Added a util file

NB: I did not add a changeset and test is scrappy

Steps to Test

yarn test packages/source/copper/test

Quality Assurance

If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
This is related to a maximum of one Jira story or GitHub issue.
Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

changeset-bot · 2025-09-03T14:27:25Z

🦋 Changeset detected

Latest commit: 0eff9cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@chainlink/copper-adapter	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/sources/copper/src/transport/utils.ts

mxiao-cll · 2025-09-08T15:15:46Z

packages/sources/copper/src/config/index.ts

+  ETHEREUM_RPC_URL: {
+    description: 'RPC url of Ethereum node',
+    type: 'string',
+    default: '',
+  },
+  ETHEREUM_RPC_CHAIN_ID: {
+    description: 'Ethereum chain id',
+    type: 'number',
+    default: 1,
+  },
+  ARBITRUM_RPC_URL: {
+    description: 'RPC url of Arbitrum node',
+    type: 'string',
+    default: '',
+  },
+  ARBITRUM_RPC_CHAIN_ID: {


Why do we need both Eth and Arbi

I was using arbitrum for USDT, USDC, SOl and ETH.
USTB is available only on Ethereum.

However, what is the thumb rule of using a price feed? Which chain do we prefer?

I'd say just use Ethereum for everything then

packages/sources/copper/src/transport/utils.ts

mxiao-cll · 2025-09-08T16:07:49Z

packages/sources/copper/src/transport/wallets.ts

+    if (param.currencies && param.currencies.length > 0) {
+      parameters.currencies = param.currencies.join(',')
+    }


Is this required? Can they just dump all currency to us in a portfolio?

When a new token is added to the portfolio, the jobspec input parameter must be configured to include the appropriate priceOracle value. This ensures that we only process currencies for which price oracles have been set up

Right but the jobSpec already contains them under the token field?

packages/sources/copper/src/transport/wallets.ts

mxiao-cll

I wrote a piece that does toUSD conversion via feeds here: https://github.com/smartcontractkit/external-adapters-js/pull/4001/files#diff-b055dd5883b7d442ff66fab11e1b72a8c60be605839d13b94e4f65323e11ec6aR13

Wonder if your EA should simply reference my EA or vice versa?

Eventually we do want to swap into the streams solution

packages/sources/copper/src/transport/utils.ts

packages/sources/copper/src/transport/wallets.ts

Subarna-Singh · 2025-09-08T19:19:35Z

packages/sources/copper/src/config/index.ts

+  ETHEREUM_RPC_URL: {
+    description: 'RPC url of Ethereum node',
+    type: 'string',
+    default: '',
+  },
+  ETHEREUM_RPC_CHAIN_ID: {
+    description: 'Ethereum chain id',
+    type: 'number',
+    default: 1,
+  },
+  ARBITRUM_RPC_URL: {
+    description: 'RPC url of Arbitrum node',
+    type: 'string',
+    default: '',
+  },
+  ARBITRUM_RPC_CHAIN_ID: {


I was using arbitrum for USDT, USDC, SOl and ETH.
USTB is available only on Ethereum.

However, what is the thumb rule of using a price feed? Which chain do we prefer?

packages/sources/copper/src/transport/utils.ts

Subarna-Singh · 2025-09-08T19:22:22Z

packages/sources/copper/src/transport/wallets.ts

Removed these comments

Subarna-Singh · 2025-09-08T19:24:29Z

packages/sources/copper/src/transport/wallets.ts

+    if (param.currencies && param.currencies.length > 0) {
+      parameters.currencies = param.currencies.join(',')
+    }


When a new token is added to the portfolio, the jobspec input parameter must be configured to include the appropriate priceOracle value. This ensures that we only process currencies for which price oracles have been set up

packages/sources/copper/src/transport/wallets.ts

Subarna-Singh · 2025-09-09T04:43:25Z

I wrote a piece that does toUSD conversion via feeds here: https://github.com/smartcontractkit/external-adapters-js/pull/4001/files#diff-b055dd5883b7d442ff66fab11e1b72a8c60be605839d13b94e4f65323e11ec6aR13

Wonder if your EA should simply reference my EA or vice versa?

Eventually we do want to swap into the streams solution

I dont understand the ask here.

Subarna-Singh · 2025-09-09T07:57:04Z

I wrote a piece that does toUSD conversion via feeds here: https://github.com/smartcontractkit/external-adapters-js/pull/4001/files#diff-b055dd5883b7d442ff66fab11e1b72a8c60be605839d13b94e4f65323e11ec6aR13
Wonder if your EA should simply reference my EA or vice versa?
Eventually we do want to swap into the streams solution

I dont understand the ask here.

I think I understand.
You want to limit call to price feeds.
Using a single EA for that and using copper/binance only for balance retrieval makes sense.

mxiao-cll · 2025-09-09T12:40:31Z

Using a single EA for that and using copper/binance only for balance retrieval makes sense.

No, I mean to re-use code that does token to USD calculation, we do want to use a single EA eventually once we switch to streams

cl-mayowa added 2 commits August 28, 2025 14:13

copper-ea wip

2bef608

wip: add copper ea

22c781a

github-advanced-security bot found potential problems Sep 3, 2025

View reviewed changes

packages/sources/copper/src/transport/utils.ts Fixed Show fixed Hide fixed

Copper EA

56ca5c2

Subarna-Singh requested a review from mxiao-cll September 8, 2025 13:14

Adding Changeset

0724ef1

Subarna-Singh marked this pull request as ready for review September 8, 2025 13:19

Subarna-Singh added 3 commits September 8, 2025 18:50

Delete unused files

cd4ef9e

FIX: lint error

038c571

update test-payload

4bce6b4

mxiao-cll reviewed Sep 8, 2025

View reviewed changes

packages/sources/copper/src/transport/utils.ts Outdated Show resolved Hide resolved

mxiao-cll reviewed Sep 8, 2025

View reviewed changes

packages/sources/copper/src/transport/wallets.ts Outdated Show resolved Hide resolved

mxiao-cll reviewed Sep 8, 2025

View reviewed changes

packages/sources/copper/src/transport/utils.ts Outdated Show resolved Hide resolved

mxiao-cll reviewed Sep 8, 2025

View reviewed changes

packages/sources/copper/src/transport/wallets.ts Show resolved Hide resolved

REWORK: review work

160d659

Subarna-Singh reviewed Sep 9, 2025

View reviewed changes

REWORK: review work

fc44472

ADD: aggregate balances to result for debugging

0eff9cd

Conversation

cl-mayowa commented Sep 3, 2025 • edited by Subarna-Singh Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Closes #OPDATA-3656

Description

Changes

Steps to Test

Quality Assurance

Uh oh!

changeset-bot bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mxiao-cll left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Subarna-Singh commented Sep 9, 2025

Uh oh!

Subarna-Singh commented Sep 9, 2025

Uh oh!

mxiao-cll commented Sep 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

cl-mayowa commented Sep 3, 2025 •

edited by Subarna-Singh

Loading

changeset-bot bot commented Sep 3, 2025 •

edited

Loading