Skip to content

Conversation

@smheidrich
Copy link
Owner

@smheidrich smheidrich commented Aug 24, 2023

2nd attempt at something that looks more like how it's done in json-stream, i.e. with a separate JSON string reader class.

Equivalent of daggaz/json-stream#47 on json-stream side.

Supersedes #84 and #89.

ToDos:

  • Change string handling in RustTokenizer
  • JsonStringReader impl.
  • Tests
    • Using json-stream's (with some xfail where not important)
    • Our own (integration tests)

Allows json-stream's JsonStringReader unit tests to work for us, too.
@smheidrich smheidrich force-pushed the string-streaming-via-sep-string-parser-struct-attempt2 branch from 0125b92 to ec680c9 Compare August 25, 2023 11:17
@smheidrich
Copy link
Owner Author

@daggaz Just to let you know: I think the most important features here are finally ready (namely, returning strings as objects that can be read() from and iterated over, if requested via strings_as_files=True) and I'm not sure the other ones (full IOBase interface implementation, exactly aligning exceptions with the Python tokenizer, etc.) are required at this point.

So I'm prepared to merge this when you are 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants