Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #280 by adding two new methods to StackSet for cycling workspaces #296

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

sminez
Copy link
Owner

@sminez sminez commented Jun 2, 2024

Adding two new methods to StackSet: focus_next_workspace and focus_previous_workspace which behave as their name implies. The definition of "next/previous" is in terms of the semantics of the ordered_tags method, so currently in terms of the workspace id. If the semantics of ordered_tags changes in future then so will the behaviour of these methods.

Testing wise there is a simple unit test that the cycling methods focus the expected tag both with and without wrapping at either end of the workspace list, along with a quickcheck test that for arbitrary StackSets with at least two workspaces we always change the focused workspace when calling either method.

@sminez sminez merged commit 210f23d into develop Jun 2, 2024
10 checks passed
@sminez sminez deleted the issue-280 branch June 2, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant