fixing #113 and adding proper mouse support #300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @favilo for the initial implementation that this was inspired by (found here) and apologies to @psychon for not addressing the issue with motion notify events until now...!
This change includes a breaking API change to how mouse bindings are defined: rather than bindings being tied individually to press, release and motion the
MouseEventHandler
trait now defines a handler that is responsible for all three for a given button press and modifier set. As a demonstration of how this looks, this is the simple mouse bindings that are now present in theminimal
example:mouse-support-demo-2024-06-22_17.03.08.mp4