Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been playing around with some ideas on how to support running Penrose as a window manager for OSX here. This requires stripping out all of the x11-isms from
core
and really making the WindowManager backend agnostic (also required for Wayland but there's a lot more work to do there). The initial state of this PR is what is required to move over to driving things using aConn
trait (rather thanXConn
) while also allowing for X11 specific behaviour if the user wants/needs it. I need to move my POC work for the OSX backend and verify that everything works so I'm leaving this up as a draft for now.It should go without saying that merging this will require a 0.4 release 😉
Conn
rather than always beingXEvent
Send
bounds are now required for most of the traits so thatWindowManager
can be moved between threads (OSX requires that it's main event loop runs on the main thread of the program)