Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task ordering #103

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Update task ordering #103

merged 3 commits into from
Oct 11, 2023

Conversation

hpmellema
Copy link
Contributor

@hpmellema hpmellema commented Oct 9, 2023

Description of changes

Updates the ordering of tasks so that:

  1. The Format task executes before the build task. This ensures any files written to an output jar will be formatted.
  2. Updates to create a dependency for the compile task on processResources. This ensures that smithy output files are in the META-INF/ output folder before the compile task is executed so they are available to the compile task for any annotation processors.

The following is an example of the new task order for the quickstart gradle template (using --dry-run)

:smithyFormat SKIPPED
:smithyBuild SKIPPED
:smithyJarStaging SKIPPED
:processResources SKIPPED
:compileJava SKIPPED
:classes SKIPPED
:jar SKIPPED
:assemble SKIPPED
:compileTestJava SKIPPED
:smithyJarValidate SKIPPED
:processTestResources SKIPPED
:testClasses SKIPPED
:test SKIPPED
:check SKIPPED
:build SKIPPED

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hpmellema hpmellema requested a review from a team as a code owner October 9, 2023 14:53
@hpmellema hpmellema merged commit 85cd5af into main Oct 11, 2023
4 checks passed
@hpmellema hpmellema deleted the update-task-ordering branch October 11, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants