Add exception on implicit empty config #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtdowling
reviewed
Feb 19, 2024
smithy-base/src/main/java/software/amazon/smithy/gradle/tasks/SmithyBuildTask.java
Outdated
Show resolved
Hide resolved
mtdowling
approved these changes
Feb 19, 2024
hpmellema
added a commit
to hpmellema/smithy-gradle-plugin
that referenced
this pull request
Mar 7, 2024
This reverts commit 59f1454.
hpmellema
added a commit
that referenced
this pull request
Mar 7, 2024
hpmellema
added a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit 590302c.
hpmellema
added a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit 590302c.
hpmellema
added a commit
that referenced
this pull request
Mar 14, 2024
This reverts commit 590302c.
hpmellema
added a commit
that referenced
this pull request
Mar 15, 2024
hpmellema
added a commit
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Previously, the plugin would use an empty
smithy-buildfile if no build configs were specified and nosmithy-build.jsoncould be found at the project root. Most of the time customers have nosmithy-buildconfig in the project or extension would be in error (this would mean no plugins or projections are configured). This can lead to customer confusion.This PR updates the plugin to require explicit acknowledgement that no build configs should be found (via empty set in
smithyBuildConfigsproperty) and throws a helpful error otherwise. If thesmithyBuildConfigsoption is set to an empty set the plugin will still use the implicit empty build config.Testing
New integration tests were added to check the behavior of this new option.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.