feat: provide client config property for region provider #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
xinsong-cui
added
the
no-changelog
This comment has been minimized.
This comment has been minimized.
lauzadis
reviewed
Jan 8, 2025
| @@ -134,6 +135,7 @@ data class KotlinDependency( | |||
| // External third-party dependencies | |||
| val KOTLIN_STDLIB = KotlinDependency(GradleConfiguration.Implementation, "kotlin", "org.jetbrains.kotlin", "kotlin-stdlib", KOTLIN_COMPILER_VERSION) | |||
| val KOTLIN_TEST = KotlinDependency(GradleConfiguration.TestImplementation, "kotlin.test", "org.jetbrains.kotlin", "kotlin-test", KOTLIN_COMPILER_VERSION) | |||
| val KOTLINX_COROUTINES = KotlinDependency(GradleConfiguration.Implementation, "kotlinx.coroutines", "org.jetbrains.kotlinx", "kotlinx-coroutines-core", KOTLINX_COROUTINES_VERSION) | |||
There was a problem hiding this comment.
Sorry, I think I gave you the wrong recommendation earlier. This could be done without hardcoding the kotlinx.coroutines version. See @0marperez PR where he does the exact same thing here: https://github.com/smithy-lang/smithy-kotlin/pull/1191/files#diff-cff225fba9b05cc2ba4b10fb157b6a2365da1a2c676cec0d06379bf14a0991ccR416
We can sync up if you have more questions
Affected ArtifactsChanged in size
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1478
Description of changes
Add Kotlin Coroutine dependency that will be used in awslabs/aws-sdk-kotlin#1488
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.