New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary signers fixes #433

Merged

alextwoods merged 1 commit into smithy-lang:develop from alextwoods:fix_signer_shorterm

Mar 12, 2025

Contributor

alextwoods commented Mar 12, 2025

Description of changes:
These changes are temporary and should be replaced by larger signer fixes.

Fixes 2 typing mismatches with the current signers:

request -> http_request in the signature for sign.
Adds a runtime_checkable AWSCredentialsIdentity(Protocol) to allow the instance_of check to succeed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


          Temporary signers fixes

0642bc6

alextwoods requested a review from a team as a code owner

March 12, 2025 19:06

nateprewitt approved these changes

View reviewed changes

alextwoods merged commit 05b8ce6 into smithy-lang:develop

2 checks passed

alextwoods deleted the fix_signer_shorterm branch

March 12, 2025 19:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet