Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass new request into signer for canonical_request #434

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Conversation

nateprewitt
Copy link
Contributor

Description of changes:
We shouldn't be mutating the base request during signing, the intended workflow is to only use the copied request.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nateprewitt nateprewitt requested a review from a team as a code owner March 12, 2025 19:56
Copy link
Contributor

@alextwoods alextwoods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to update below: signing_fields = await self._normalize_signing_fields(request=http_request)

alextwoods
alextwoods previously approved these changes Mar 12, 2025
alextwoods
alextwoods previously approved these changes Mar 12, 2025
@nateprewitt nateprewitt merged commit 0c9d105 into develop Mar 12, 2025
2 checks passed
@nateprewitt nateprewitt deleted the signer_fix branch March 12, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants