Remove use of thread locks in crt bindings #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This primarily serves the purpose of removing thread-based locks from the CRT bindings, but it also ensures that the status code and headers have been received before returning from send.
JordonPhillips
force-pushed
the
await-crt-initial-http
branch
from
28f7884 to
16c5e4e
Compare
JordonPhillips
changed the title
alextwoods
previously approved these changes
Mar 13, 2025
| def on_response( | ||
| self, status_code: int, headers: list[tuple[str, str]], **kwargs: Any | ||
| ) -> None: # pragma: crt-callback | ||
| print("on-response") |
nateprewitt
requested changes
Mar 13, 2025
nateprewitt
approved these changes
Mar 13, 2025
alextwoods
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This primarily serves the purpose of removing thread-based locks from the CRT bindings, but it also ensures that the status code and headers have been received before returning from send.
Thread-based
Locks will deadlock if acquired twice by the same thread, so it's likely to happen in async code that runs multiple coroutines in one thread. And also,deques are already thread-safe so there's no need to protect them further.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.