Copy request for each attempt / don't retry client errors #460
+30
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
previously approved these changes
Mar 20, 2025
JordonPhillips
requested changes
Mar 21, 2025
Co-authored-by: Jordon Phillips <[email protected]>
nateprewitt
approved these changes
Mar 21, 2025
JordonPhillips
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In #449 the
copyon request context when calling_handle_attemptwas removed and thecopymethod on interceptor context was removed as well. This breaks endpoint construction during _handle_attempt - without a copy of the request, the destination is modified for each attempt.Additionally, this PR removes retries for client errors from the SimpleRetryStrategy.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.