Use base ruff config for all projects #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
sort-imports
branch
from
af5206a to
c435dbf
Compare
nateprewitt
previously approved these changes
Mar 21, 2025
jonathan343
reviewed
Mar 21, 2025
| @@ -50,7 +48,7 @@ def __init__( | |||
|
|
|||
| async def send(self, event: E) -> None: | |||
| if self._closed: | |||
| raise IOError("Attempted to write to closed stream.") | |||
There was a problem hiding this comment.
For reviewers also wondering, this is related to: https://docs.astral.sh/ruff/rules/os-error-alias/
jonathan343
previously approved these changes
Mar 21, 2025
JordonPhillips
dismissed stale reviews from jonathan343 and nateprewitt
via
ef1d10d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we weren't sorting imports despite having that configured in our
pyproject.toml. Turns out ruff wasn't using the top-level config at all. So I fixed it. There were a few minor manual fixes that had to be made too, and a few noqa's had to be added.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.