Add deprecation warning to S3 GetBucketLocation operation #4348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add DeprecatedTrait to GetBucketLocation operation in S3Decorator - Include message recommending HeadBucket as the preferred alternative - Add comprehensive unit tests to verify deprecation behavior - Add integration test to verify generated Rust code includes #[deprecated] attribute This addresses customer feedback that GetBucketLocation is marked as deprecated in AWS documentation but not in the Rust SDK.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aws/codegen-aws-sdk/src/main/kotlin/software/amazon/smithy/rustsdk/customize/s3/S3Decorator.kt
Outdated
Show resolved
Hide resolved
...degen-aws-sdk/src/test/kotlin/software/amazon/smithy/rustsdk/customize/s3/S3DecoratorTest.kt
Outdated
Show resolved
Hide resolved
- Changed createDeprecatedTrait() to take message as parameter - Updated deprecatedOperations from Set to Map for message storage - Removed integration test per code review feedback
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
It is reported that the S3 GetBucketLocation operation is marked as deprecated in the AWS S3 documentation, but the Rust SDK doesn't reflect this deprecation with a compiler warning.
The AWS documentation recommends using HeadBucket instead to determine a bucket's region.
Description
This PR adds the Smithy @deprecated trait to the GetBucketLocation operation in the S3Decorator, which generates a Rust #[deprecated] attribute in the SDK.
Changes:
Deprecation Message:
Testing
Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.