Skip to content

fix: Fix StreamableHttpBody's isEndOfStream bug #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

fix: Fix StreamableHttpBody's isEndOfStream bug #929

merged 1 commit into from
May 14, 2025

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented May 12, 2025 •
edited
Loading

aws-sdk-swift PR for running integ tests against this change:

Issue #

N/A

Description of changes

  • Fixes a bug where chunked streaming Data payload gets cut prematurely due to wrong isEndOfStream implementation

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sichanyoo sichanyoo mentioned this pull request May 12, 2025
Closed
@sichanyoo sichanyoo requested review from jbelkins and dayaffe May 12, 2025 21:01
@sichanyoo sichanyoo merged commit 6ff0a0c into main May 14, 2025
52 of 57 checks passed
@sichanyoo sichanyoo deleted the fix/streamable-http-body-isEndOfStream branch May 14, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbelkins jbelkins jbelkins approved these changes

@dayaffe dayaffe Awaiting requested review from dayaffe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sichanyoo @jbelkins