fix: Silenced network error in CRTClientEngine onStreamComplete callback #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
reviewed
May 27, 2025
| @@ -571,6 +571,7 @@ public class CRTClientEngine: HTTPClient { | |||
| case .failure(let error): | |||
| self.logger.error("Response encountered an error: \(error)") | |||
| stream.closeWithError(error) | |||
| continuation.resume(throwing: error) | |||
There was a problem hiding this comment.
We're sure we don't need this in the success branch of the switch as well?
There was a problem hiding this comment.
I think so, the success with status code means valid response was returned from the service, meaning onResponse would've been called already that resumes the continuation. Not to mention customer's been using v1.2.9 of aws-sdk-swift that depends on v.0.112.0 of smithy-swift without any issues, which only has this resume logic in failure case.
There was a problem hiding this comment.
OK, I guess we can re-evaluate if we see this problem reoccur.
jbelkins
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Adds back
continuation.resume(throwing:)toonStreamCompletecallback inCRTClientEngine. The continuation resumption was removed in this previous PR: #922. At the time of removal, the logic was that by the timeonStreamCompletecallback is reached, the continuation must have been resumed in theonResponsecallback sinceonResponsecallback gets called as soon as we get headers from the service. But on transient network errors, only theonStreamCompletecould get called &onResponsecould be skipped. This causes continuation to never get resumed, silencing error & essentially "freezing" a thread.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.