chore!: Eliminate public Foundation.Date extension #931
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
ClientRuntime
-specificDate
type.ClientRuntime
doesn't need its ownDate
.Foundation.Date
since such extensions on other modules' types can result in name collisions.aws-sdk-swift PR awslabs/aws-sdk-swift#1947 depends on this change. Since the logic in the deleted extension is only ever used in one place, it is reproduced inline when needed in aws-sdk-swift.
This change is breaking because it eliminates the
ClientRuntime.Date
type and the.withoutFractionalSeconds()
extension. Customer impact should be zero since these types are only used in non-customer-facing components.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.