Skip to content

chore!: Eliminate public Foundation.Date extension #931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented May 30, 2025

Description of changes

  • Eliminates the creation by typealias of a ClientRuntime-specific Date type. ClientRuntime doesn't need its own Date.
  • Eliminates the public extension on Foundation.Date since such extensions on other modules' types can result in name collisions.

aws-sdk-swift PR awslabs/aws-sdk-swift#1947 depends on this change. Since the logic in the deleted extension is only ever used in one place, it is reproduced inline when needed in aws-sdk-swift.

This change is breaking because it eliminates the ClientRuntime.Date type and the .withoutFractionalSeconds() extension. Customer impact should be zero since these types are only used in non-customer-facing components.

Scope

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins changed the title chore\!: Eliminate public Foundation.Date extension chore!: Eliminate public Foundation.Date extension May 30, 2025
@jbelkins jbelkins marked this pull request as ready for review June 2, 2025 16:22
@jbelkins jbelkins requested review from dayaffe and sichanyoo June 2, 2025 16:22
@jbelkins jbelkins merged commit dc3368a into main Jun 2, 2025
33 checks passed
@jbelkins jbelkins deleted the jbe/runtime_deps_cleanup branch June 2, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants