feat: Credential feature IDs #945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichanyoo
commented
Jul 3, 2025
| @@ -6,8 +6,10 @@ | |||
| // | |||
|
|
|||
| import struct Foundation.Date | |||
| import struct Smithy.Attributes | |||
There was a problem hiding this comment.
Adds grab-bag property called properties to AWSCredentialIdentity. For now it's only used for business metrics feature IDs for credentials. Feature IDs are AWS specific and so this property bag acts as a way to keep smithy-swift generic. Not to mention it allows maximum flexibility for miscellaneous values not fundamental to credential object itself, in case SDK needs to store even more misc. AWS specific values with credential objects down the line.
All the other changes in this PR is just to accommodate this addition to the protocol.
jbelkins
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding PR:
Issue #
2302
Description of changes
propertiesfield to identity types.Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.