feat: Checksum reuse between retries in chunked streaming requests #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
reviewed
Jul 11, 2025
| hashResult = cachedChecksum | ||
| } else { | ||
| hashResult = try checksum.digest().toBase64String() | ||
| context.set(key: AttributeKey<String>(name: "ChunkedStreamCachedChecksum"), value: hashResult) |
There was a problem hiding this comment.
nit: can we avoid directly typing out "ChunkedStreamCachedChecksum" and either use a variable or add it where the other AttributeKeys live
dayaffe
approved these changes
Jul 11, 2025
jbelkins
reviewed
Jul 14, 2025
| @@ -57,6 +57,11 @@ extension SignerMiddleware: ApplySigner { | |||
| updatedSigningProperties.set(key: AttributeKey(name: "SignedBodyValue"), value: bodyValue) | |||
| } | |||
|
|
|||
| if case .stream(let stream) = request.body, stream.isEligibleForChunkedStreaming { | |||
| // Pass in context object via signing properties to reuse final checksum value in chunked streaming. | |||
| updatedSigningProperties.set(key: AttributeKey(name: "Context"), value: attributes) | |||
There was a problem hiding this comment.
Be careful here... if we put Context into signing properties then we put those signing properties into Context, a reference cycle is formed and a memory leak will occur.
Maybe better to copy the specific things we need from Context into signingProperties?
jbelkins
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR:
Issue #
3359
Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.