Skip to content

Part of SAAS-2959 - Lowering go version to 1.23 for better compatibility. #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

andream16
Copy link
Contributor

@andream16 andream16 commented Jun 25, 2025

We need to downgrade to go 1.23.4 for better compatibility.

Before doing this, I also downgraded pkg/retry's version.

This PR:

  • Updates the deps on the retry package to v0.0.3
  • Uses a fixed and existing version for the languages package. This was leading to issues earlier.
  • Downgrades modules and Dockerfiles go version to v1.23.4

Tested with some sample workflows and builds ok.

@andream16 andream16 force-pushed the andream16/lower-go-version-to-1.23 branch 2 times, most recently from 2097e4d to 48c445a Compare June 26, 2025 09:19
@coveralls
Copy link

coveralls commented Jun 26, 2025

Pull Request Test Coverage Report for Build 15898851534

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.04%

Totals Coverage Status
Change from base Build 15824729473: 0.0%
Covered Lines: 846
Relevant Lines: 2224

💛 - Coveralls

@andream16 andream16 force-pushed the andream16/lower-go-version-to-1.23 branch from 48c445a to 1e65fac Compare June 26, 2025 09:47
@andream16 andream16 force-pushed the andream16/lower-go-version-to-1.23 branch from 1e65fac to 43aa24e Compare June 26, 2025 09:59
@andream16 andream16 self-assigned this Jun 26, 2025
@andream16 andream16 requested a review from ptzianos June 26, 2025 10:02
@andream16 andream16 merged commit 23c2703 into main Jun 26, 2025
8 checks passed
@andream16 andream16 deleted the andream16/lower-go-version-to-1.23 branch June 26, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants