make the pdf reporter upload to any configurable s3 backend, not only… #1055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
northdpole
force-pushed
the
make-pdf-reporter-upload-to-configurable-s3-backends
branch
from
c384053 to
468292e
Compare
Pull Request Test Coverage Report for Build 16479616874Details
💛 - Coveralls |
northdpole
force-pushed
the
make-pdf-reporter-upload-to-configurable-s3-backends
branch
3 times, most recently
from
fe1959e to
836b0c3
Compare
northdpole
force-pushed
the
make-pdf-reporter-upload-to-configurable-s3-backends
branch
from
836b0c3 to
d466ee0
Compare
dlicheva
reviewed
Jul 25, 2025
| } | ||
| } | ||
|
|
||
| // WithEndpoint allows providing a custom AWS region. |
| for _, opt := range opts { | ||
| config = opt(config) | ||
| } | ||
| if config.Endpoint != nil { // a lot of local/testing S3 implementations that need custom endoints do not support the default subdomain style |
There was a problem hiding this comment.
is it worth returning an error according to this comment, so the user knows why it doesn't work?
| true, | ||
| append(envOpts, env.WithDefaultOnError(false))..., | ||
| false, | ||
| append(envOpts, env.WithDefaultOnError(true))..., |
There was a problem hiding this comment.
When that is set to false, we are always requiring an upload of the PDF to a bucket. This makes it more difficult to test locally.
| pdf: | ||
| - name: "bucket_endpoint" | ||
| type: "string" | ||
| value: "" |
There was a problem hiding this comment.
Would that example be simpler if we skip the s3 upload (since it's local)?
| logger := componentlogger.LoggerFromContext(ctx) | ||
|
|
||
| if conf.Bucket == "" { | ||
| err := errors.New("bucket is empty, you need to provide a bucket name") |
There was a problem hiding this comment.
That's already checked in the uploadToS3() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… aws
fixes #1031