Merged
Conversation
the lint Make target will output in stderr all the issues that reviewdog discovered for the diff under investigation, however that stderr is not captured by the Github action. we need to send the stderr to stdout so that we can see it in the Github action logs when the lint action fails.
9d7650b to
1677b01
Compare
northdpole
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the lint Make target will output in stderr all the issues that reviewdog discovered for the diff under investigation, however that stderr is not captured by the Github action. we need to send the stderr to stdout so that we can see it in the Github action logs when the lint action fails.