Skip to content

Update chrome_driver.py to add version detection #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brandoncasaba
Copy link
Contributor

Prevent version mismatch on chrome driver by detecting installed version fixing #116

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (22ccf8c) to head (fc4957b).

Files with missing lines Patch % Lines
safeway_coupons/chrome_driver.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   81.94%   82.65%   +0.70%     
==========================================
  Files          14       14              
  Lines         504      513       +9     
==========================================
+ Hits          413      424      +11     
+ Misses         91       89       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@a1ch3mist
Copy link

a1ch3mist commented Apr 2, 2025

Will this mean we don't have to update the Chrome browser when the error occurs?
Currently when it happens I go to Chrome and update there and all resolves.

@brandoncasaba
Copy link
Contributor Author

Will this mean we don't have to update the Chrome browser when the error occurs? Currently when it happens I go to Chrome and update there and all resolves.

Yes, feel free to update to latest version, but it won't attempt to just guess at the version by using the latest available on the interwebs, but rather it will use the version detected preventing the error messages entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants