Replace async-channel with flume #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces async-channel in some tests with flume. It appears that async-channel doesn't work under MIRI but flume does, so we can work around this for now by replacing it with flume. cc smol-rs/async-channel#85 Signed-off-by: John Nunley <[email protected]>
|
I can't emulate the MIRI failure here on my machine unless I run it inside of a Docker container with only three CPUs. |
Signed-off-by: John Nunley <[email protected]>
|
We got another Miri error today... https://github.com/smol-rs/async-lock/actions/runs/8769497281/job/24065046417#step:4:219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces async-channel in some tests with flume. It appears
that async-channel doesn't work under MIRI but flume does, so we can
work around this for now by replacing it with flume.
cc smol-rs/async-channel#85