Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: listen on all ports #814

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

chayleaf
Copy link
Contributor

@chayleaf chayleaf commented Jul 13, 2023

This would close #809. It can also allow rebinding the UDP socket port, but that isn't implemented (granted, it's a single-line change)

I've still to create examples, tests and documentation, I'm publishing it in this state to get some feedback

@chayleaf chayleaf changed the title RFC: listen on any port RFC: listen on all ports Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #814 (1e7040d) into main (f9b064a) will decrease coverage by 0.06%.
The diff coverage is 70.12%.

@@            Coverage Diff             @@
##             main     #814      +/-   ##
==========================================
- Coverage   79.65%   79.59%   -0.06%     
==========================================
  Files          72       72              
  Lines       27862    27947      +85     
==========================================
+ Hits        22193    22245      +52     
- Misses       5669     5702      +33     
Impacted Files Coverage Δ
src/socket/udp.rs 81.92% <68.49%> (-2.96%) ⬇️
src/socket/tcp.rs 96.48% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raftario
Copy link

Just chiming in to show interest in the feature, not sure how to feel about the UDP implementation and method names though. Also I feel like it might make more sense to update ListenEndpoint to take an Option<u16> to reflect the existing behaviour for addresses and since binding to port 0 going from being an error to matching any port would be a massive footgun for people upgrading versions as the change wouldn't cause any compile errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support listening on multiple ports with a single socket
2 participants