-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VLAN support #902
base: main
Are you sure you want to change the base?
Add VLAN support #902
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
==========================================
- Coverage 79.96% 79.66% -0.30%
==========================================
Files 82 83 +1
Lines 28378 28783 +405
==========================================
+ Hits 22693 22931 +238
- Misses 5685 5852 +167 ☔ View full report in Codecov by Sentry. |
Ok, so first thing is to figure out how to integrate VLAN into existing tests for coverage. |
Since |
@thvdveld I implemented your remarks a while back but forgot to write a new comment here. |
I'm not really comfortable merging this as I'm not familiar with the VLAN/Ethernet implementation. Maybe @Dirbaio or @whitequark could take a look? |
This is a large and complex PR and I won't be reviewing it as-is; splitting it into multiple parts, starting with the |
This PR adds basic VLAN support.
There are probably some things missing since I am not yet that familiar with the codebase. I hope that you can point me in the right direction.
If you add the VLAN config option to the loopback example it works and you can see the tags in the output as well as in the recorded pcap file.