multicast: use single Cargo feature for both ipv4 and ipv6. #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The multicast feature was somewhat broken before, there was no way to do IPv6-only multicast since a lot of multicast code was gated behind `proto-igmp` which force-enables ipv4. Solution: - Added feature `multicast` which enables multicast for ipv4 and/or ipv6, whatever the user has enabled. - Removed feature `proto-igmp`. IGMP support in `wire` is always built if ipv4 is enabled. This causes no bloat if unused, and the increase in compile time is negligible. `iface` only uses it if the `multicast` feature is enabled.
Dirbaio
force-pushed
the
multicast-refactor-features
branch
from
67ad83f
to
07f0991
Compare
|
ready to go now that #985 is merged |
whitequark
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #985
multicast: use single Cargo feature for both ipv4 and ipv6.
The multicast feature was somewhat broken before, there was no way to do IPv6-only multicast
since a lot of multicast code was gated behind
proto-igmpwhich force-enables ipv4.Solution:
multicastwhich enables multicast for ipv4 and/or ipv6, whatever the user has enabled.proto-igmp. IGMP support inwireis always built if ipv4 is enabled. This causes no bloat if unused, and the increase in compile time is negligible.ifaceonly uses it if themulticastfeature is enabled.