Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fresh start on the UTStats modernization #21

Open
wants to merge 3 commits into
base: update-to-mysqli
Choose a base branch
from

Conversation

elsheepo
Copy link

@elsheepo elsheepo commented Feb 3, 2019

  • Applying the responsive, mobile friendly Boostrap 4 CSS framework.
  • Editing PHP echo statements to output properly formatted HTML.
  • Migrate all mysqli calls to PDOs for SQL Injection security.

1. Applying the responsive, mobile friendly Boostrap 4 CSS
    framework.
2. Editing PHP echo statements to output properly formatted
    HTML.
3. Migrate all mysqli calls to PDOs for SQL Injection security.
@elsheepo
Copy link
Author

elsheepo commented Feb 3, 2019

I'm very unfamiliar with Git in general, and github even more so. I'm not sure how this whole forking, branches, pull requests thing works, so I'm just gana focus on the code, and if I can't figure out how to do the git thing properly, I'll just redistribute it as best as can as per the LICENCE.

@davidbernard04
Copy link
Contributor

@elsheepo, by the way there are some guides in github that show really well how to work with github: https://guides.github.com/activities/hello-world/

@sn3p
Copy link
Owner

sn3p commented Feb 28, 2019

@elsheepo thanks for the PR!

I'm very unfamiliar with Git in general, and github even more so. I'm not sure how this whole forking, branches, pull requests thing works

You're doing great so far! Let me know if you have any questions or need help.

Some guidelines and best practices:

  1. Focus on the issue/feature you're working on, e.g. I prefer no changes in the layout (html/css) when you're upgrading PHP/MySQL (different fixes in different PRs).
  2. Create small commits with meaningful chunks of code and commit messages.
  3. I prefer 2 spaces for indenting, not more and no tabs ;)

These are very important because this makes it easier to review and debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants