standardise link/counter names #1025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notable change: link counters are reversed: - input == enqueued onto the link - output == dequeued from the link
eugeneia
changed the title
# Conflicts: # src/apps/intel/intel_app.lua # src/apps/tap/tap.lua # src/apps/test/match.lua # src/apps/vlan/vlan.lua
|
Great initiative! Have only given it a quick run-through but no problems jump out at me. |
|
See further discussion in #1030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #871 this PR the shorthands “rx” and “tx” are removed from link and counter (SHM) names and replaced with “input” and “output”. This change affects many modules and the changes to each module should be reviewed by their authors/maintainers.
The most notable change that the translation is reversed for link counters, e.g. rx is now output and tx is input, e.g.:
Depends on: #1019