Archive /var/run/snabb/PID directory in case of crash #1378
Conversation
There was a problem hiding this comment.
I think this approach won't really solve the use case because there won't be any interesting counters any more. Firstly I should say that I'm mostly concerned about ptree workers; handling the general case is possible but we definitely have to handle the ptree worker case.
In that regard, this approach won't work; often exits are orderly, and in that case the handler isn't called. Disorderly exits don't always neatly propagate through an exception; if we want to handle that case, we should archive from the supervisor.
However more to the point, ptree does an engine.configure(config.new()) before stopping, so all of the apps get shut down in an orderly way. This will remove the counters and RRD files that we wanted to archive!
Archiving should also be optional. Right now we won't cause the disk to fill up. Systematically archiving could cause us to enter this state. Consider controlling via an environment variable.
Also probably we should only archive .counter and .rrd files.
2 participants
Solves #1352.