-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arm64 architecture #48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fails to build and has conflicts with the main branch. @ThyMYthOS do you want to continue working on it, or should we close this PR?
The version is outdated anyway. I will give it another try using your suggestions. |
@merlijn-sebrechts seems that |
It seems like it's building on X86_64! Have you tested this on Alternatively, you could modify the GitHub action to also build on arm, like we do for gimp: https://github.com/snapcrafters/gimp/blob/master/.github/workflows/build-prs.yml How do you want to proceed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just built this locally for amd64, and also tested remote-buiild
for arm64
and it's all good! I'll merge this and follow up another time with a CI uplift to follow the latest actions. Thanks!
Edit: heh, I can't merge unless there is another review.
Build logs for arm64 attached.
eclipse_arm64.txt
No description provided.