Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arm64 architecture #48

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Conversation

ThyMYthOS
Copy link
Contributor

No description provided.

snap/snapcraft.yaml Outdated Show resolved Hide resolved
Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails to build and has conflicts with the main branch. @ThyMYthOS do you want to continue working on it, or should we close this PR?

@ThyMYthOS
Copy link
Contributor Author

The version is outdated anyway. I will give it another try using your suggestions.

@ThyMYthOS
Copy link
Contributor Author

@merlijn-sebrechts seems that source-checksum does not support advanced grammar. Any idea how to solve this?

@merlijn-sebrechts
Copy link
Member

It seems like it's building on X86_64!

Have you tested this on arm yourself? If you don't have an arm device, you can use remote-build to build on the launchpad builders from your local machine: https://snapcraft.io/docs/remote-build

Alternatively, you could modify the GitHub action to also build on arm, like we do for gimp: https://github.com/snapcrafters/gimp/blob/master/.github/workflows/build-prs.yml

How do you want to proceed?

Copy link
Member

@jnsgruk jnsgruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just built this locally for amd64, and also tested remote-buiild for arm64 and it's all good! I'll merge this and follow up another time with a CI uplift to follow the latest actions. Thanks!

Edit: heh, I can't merge unless there is another review.

Build logs for arm64 attached.
eclipse_arm64.txt

@jnsgruk jnsgruk merged commit fc81528 into snapcrafters:master Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants