ci: use common snapcrafters ci; update README #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsgruk
requested review from
a team,
lucyllewy and
merlijn-sebrechts
and removed request for
a team
|
@ThyMYthOS can you take a look at this? I can't seem to tag you as a reviewer 🤷♂️ |
jnsgruk
force-pushed
the
ci
branch
2 times, most recently
from
ae05926
to
826cda2
Compare
ThyMYthOS
suggested changes
Feb 21, 2024
| @@ -0,0 +1,25 @@ | |||
| name: Promote | |||
There was a problem hiding this comment.
Not sure, if we should promote to stable via GitHub, since we don't have proper regression tests to do this automatically.
There was a problem hiding this comment.
The promotion would only happen by one of the maintainers issuing a slash command - and after the app is launched and automatically screenshotted to ensure it launches
There was a problem hiding this comment.
See here for an example: snapcrafters/signal-desktop#269
|
Yes! This "candidate" branch will map to the "latest" track in the store, but we can create additional branches/tracks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds remaining snapcrafters workflows and updates the README to the latest template.