-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: take into account hideAbstain
when computing results
#1091
base: master
Are you sure you want to change the base?
feat: take into account hideAbstain
when computing results
#1091
Conversation
hideAbstain
when computing results
e5b2df9
to
92edb6d
Compare
…ttps://github.com/snapshot-labs/sx-monorepo into feat-implement-hide-abstain-into-quorum-calculation
); | ||
} | ||
|
||
return proposal.scores_total; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd keep Number conversions, our types are inaccurate (we get strings/bigints/numbers in them) 😆
quorum_type: 'rejection', | ||
type: 'basic' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add test case for hide_abstain
.
Please dont merge this PR. This feature is not much used and its actually not working fully the way it was designed, technically we should store at the proposal level if it use hide abstain and compute quorum based on that. On v1 we show different quorum at the feed or at the proposal level its misleading. |
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/380
This PR uses the
hideAbstain
property in the space settings, when computing results.When
hideAbstain
is enabled,abstain
in basic voting is ignored from the quorum and resultsHow to test
hideAbstain
enabled: http://localhost:8080/#/s:safe.eth/proposal/0x5cf64434792565591b005460db0460e9314753178d4aa5475dfc0ce4d45638a2abstain
choice from the results list, and quorum should not take abstain scores into account. Results should be same as v1 https://v1.snapshot.box/#/safe.eth/proposal/0x5cf64434792565591b005460db0460e9314753178d4aa5475dfc0ce4d45638a2Notes
Excluding ABSTAIN from all scores results in lower quorum, and is marking a proposal that have passed before this PR as rejected (see the example proposal above)
Since the
hide_abstain
option can change proposal outcome depending on its setting, it should not be a global option, and each proposal should have its own local copy (likeprivacy
)