Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip premium networks message for guest user #1141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Feb 4, 2025

Summary

This PR will not show the premium networks message for guest user (they will see the "Not enough voting power" message instead)

@wa0x6e wa0x6e requested review from ChaituVR and bonustrack February 4, 2025 10:50
@wa0x6e wa0x6e marked this pull request as ready for review February 4, 2025 10:50
@ChaituVR
Copy link
Member

ChaituVR commented Feb 4, 2025

they will see the "Not enough voting power" message instead

Not sure this msg makes sense if wallet is not connected,
I think we should ask user to connect wallet instead or show connect button on editor page as well

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Feb 4, 2025

they will see the "Not enough voting power" message instead

Not sure this msg makes sense if wallet is not connected, I think we should ask user to connect wallet instead or show connect button on editor page as well

This is the default behavior before the premium network warning message PR.
This PR wil only fix the current issue with the premium network message, what you mentionned should be addressed in another PR

@ChaituVR
Copy link
Member

ChaituVR commented Feb 4, 2025

@bonustrack not too sure why we want to remove the premium network message for guest user. they are not supposed to know about it?

@wa0x6e
Copy link
Contributor Author

wa0x6e commented Feb 4, 2025

A login message would be more relevant here

@ChaituVR ChaituVR removed their request for review February 6, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants