Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show message for flagged spaces in editor #1151

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: show message for flagged spaces in editor #1151

wants to merge 1 commit into from

Conversation

ChaituVR
Copy link
Member

@ChaituVR ChaituVR commented Feb 6, 2025

Summary

  • If flagged space is trying to create a proposal, we are not displaying any message

How to test

  1. Go to a flagged space for ex:
    http://localhost:8080/#/s:003548.eth/create
  2. You should see this message
    image

@ChaituVR ChaituVR requested a review from bonustrack February 6, 2025 07:36
@ChaituVR ChaituVR mentioned this pull request Feb 6, 2025
Merged
@bonustrack
Copy link
Member

We should also show the ( ! ) badge in red next to the space name for flagged spaces

@bonustrack
Copy link
Member

bonustrack commented Feb 10, 2025 •
edited
Loading

I see 2 messages here: http://localhost:8080/#/s:katharineruth.eth/create/mqzcbf , we should always show only 1
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack Awaiting requested review from bonustrack

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChaituVR @bonustrack