Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add skin preview #1153

Open
wants to merge 12 commits into
base: feat-customize-skin-colors
Choose a base branch
from
Open

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Feb 6, 2025

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/418
Closes: https://github.com/snapshot-labs/workflow/issues/416

This PR:

  • adds a previewer to preview the skin update in realtime
  • apply the new skin on space settings change

How to test

  1. Go to your space setting > whitelabel on main site
  2. Preview is disabled
  3. Go to your space settings > whitelabel on your space custom domain
  4. Preview is enabled
  5. Edit the form (colors, theme and custom logo)
  6. The preview should update live
  7. Save your settings
  8. It should apply your new colors on save

@wa0x6e wa0x6e changed the title Feat-skin-preview feat: add skin preview Feb 6, 2025
@wa0x6e wa0x6e force-pushed the feat-skin-preview branch from d5d49c0 to 5405c1c Compare February 8, 2025 18:16
@wa0x6e wa0x6e force-pushed the feat-skin-preview branch from 913620a to 1a640ce Compare February 9, 2025 21:40
@wa0x6e wa0x6e marked this pull request as ready for review February 9, 2025 22:09
@bonustrack
Copy link
Member

Looks great! Some feedback:

  • Ideally user should be able try preview and change colors even if the site is not setup

  • If that's too much work we should at least remove the preview if the domain is not set, currently it show an incomplete sentence:

image
  • We should allow empty values, this is part of the default form
image
  • Can we use native color picker with <input type="color"...> when user click on the color square?

@bonustrack
Copy link
Member

Here is how to restyle input color https://codepen.io/leemartin/pen/ExPXRzx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants