refactor: use generated types for common API #1157
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sekhmet
force-pushed
the
sekhmet/graphql-codegen
branch
from
e966e4d to
a25ce8d
Compare
We never return null in arrays so we need to match it in our types.
Sekhmet
force-pushed
the
sekhmet/graphql-codegen
branch
from
a25ce8d to
86264eb
Compare
pscott
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With this checkpoint-labs/checkpoint#338 and this change we will be able to generate types from real GraphQL schema instead of creating it on our own.
There should be no functional changes
How to test