chore: use internal link to space creation on landing page #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sekhmet
force-pushed
the
sekhmet/create-space-link
branch
from
d56d3e5 to
36e480b
Compare
ChaituVR
approved these changes
Feb 10, 2025
Comment on lines
37
to
44
| <AppLink | ||
| :to="{ | ||
| name: 'create', | ||
| params: { | ||
| protocol: 'snapshot' | ||
| } | ||
| }" | ||
| > | ||
| Create a space | ||
| <IH-arrow-sm-right class="inline-block -rotate-45" /> | ||
| </a> | ||
| </AppLink> |
There was a problem hiding this comment.
Maybe we need two links, one for snapshot, one for x
There was a problem hiding this comment.
I would keep only the link for Snapshot offchain first, I can't find a label that would not take too much space. Anyhow we will make a page /create with both S and SX choices later
wa0x6e
requested changes
Feb 10, 2025
Sekhmet
force-pushed
the
sekhmet/create-space-link
branch
from
36e480b to
660f39b
Compare
bonustrack
reviewed
Feb 10, 2025
| :to="{ | ||
| name: 'create-space-snapshot' | ||
| }" | ||
| > | ||
| Create a space | ||
| <IH-arrow-sm-right class="inline-block -rotate-45" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pointing to offchain form because it's what it did previously.
Closes: https://github.com/snapshot-labs/workflow/issues/445
How to test